Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation deps support for Objective-C #17962

Closed
wants to merge 5 commits into from
Closed

Add implementation deps support for Objective-C #17962

wants to merge 5 commits into from

Conversation

ivan-golub
Copy link
Contributor

Implements feature #17646

This was referenced Apr 3, 2023
Closed
Closed
@ivan-golub ivan-golub changed the title Add implementaion deps support for Objective-C Add implementation deps support for Objective-C Apr 3, 2023
@ivan-golub
Copy link
Contributor Author

FYI: @xiemotongye @yongjincho92

This was referenced Apr 4, 2023
Closed
Closed
@xiemotongye
Copy link

It seems that rules_xcodeproj has fixed the bugs.
May I make so bold as to ask when this pull request would be merged?
I can't wait to use this.

@BalestraPatrick
Copy link
Member

We also would like to use this. Maybe we can turn this PR into "Ready for review" and get someone from the Bazel team to give it a look?

@xiemotongye
Copy link

@keith
Could you review this PR?

@ivan-golub ivan-golub marked this pull request as ready for review April 27, 2023 02:48
@ivan-golub ivan-golub requested review from a team and lberki as code owners April 27, 2023 02:48
@ivan-golub ivan-golub requested review from aiuto and removed request for a team April 27, 2023 02:48
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions labels Apr 27, 2023
@aiuto aiuto requested review from googlewalt and removed request for aiuto April 27, 2023 02:53
@gregestren gregestren added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 27, 2023
@sgowroji
Copy link
Member

Hi @ivan-golub, Could you please address the build-kite failures so that the PR above can be merged. Thanks!

@ivan-golub
Copy link
Contributor Author

@sgowroji sorry for that, my last documentation commit had issues, not all should be good. @gregestren @sgowroji PTAL again

@gregestren
Copy link
Contributor

@sgowroji does your import have the latest commits that the last comment mentions?

@sgowroji
Copy link
Member

sgowroji commented May 2, 2023

Hi @gregestren, I have reimported it after that last and recent commit and shared it with you. Thanks!

@copybara-service copybara-service bot closed this in ae7b9c5 May 3, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 3, 2023
@brentleyjones
Copy link
Contributor

We should get this into 6.x

@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label May 3, 2023
@keertk
Copy link
Member

keertk commented May 3, 2023

@bazel-io fork 6.2.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label May 3, 2023
@bazel-io bazel-io mentioned this pull request May 3, 2023
Closed
@keertk
Copy link
Member

keertk commented May 3, 2023

Hi @brentleyjones @gregestren @ivan-golub if we want this in 6.2, could you submit a PR against the release-6.2.0 branch please? There are some conflicts and looks like additional commits may need to be cherry-picked first.

@keertk
Copy link
Member

keertk commented May 3, 2023

Since we're quite far along the 6.2 release process, we're moving this one to 6.3.

@ivan-golub
Copy link
Contributor Author

Sounds good. Will work on cherry-pick to 6.3

@ivan-golub ivan-golub deleted the ig/objc_impl_deps branch May 4, 2023 00:21
@ivan-golub
Copy link
Contributor Author

@keertk looks like release-6.3.0 is not yet available. What would be the best target branch to choose for cherry-pick of this change?

@keertk
Copy link
Member

keertk commented May 4, 2023

Hey @ivan-golub the 6.3 branch isn't ready yet. We'll create it once 6.2 is out in a few days. I'll keep you posted.

@keertk
Copy link
Member

keertk commented May 10, 2023

The release-6.3.0 branch is now ready and open for PR submissions.

ivan-golub added a commit to ivan-golub/bazel that referenced this pull request May 11, 2023
@ivan-golub
Add implementation deps support for Objective-C
51f83a4 
Implements feature bazelbuild#17646

Closes bazelbuild#17962.

PiperOrigin-RevId: 528970146
Change-Id: Ic4b9000dfc1eebeef31db32fcab146f1b88f6c35
@ivan-golub ivan-golub mentioned this pull request May 11, 2023
Merged
@ivan-golub ivan-golub mentioned this pull request May 23, 2023
Open
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
@ivan-golub @fweikert
Add implementation deps support for Objective-C
2564b02 
Implements feature bazelbuild#17646

Closes bazelbuild#17962.

PiperOrigin-RevId: 528970146
Change-Id: Ic4b9000dfc1eebeef31db32fcab146f1b88f6c35
@keith keith mentioned this pull request Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith keith keith approved these changes

@gregestren gregestren gregestren approved these changes

@lberki lberki Awaiting requested review from lberki lberki is a code owner

@googlewalt googlewalt Awaiting requested review from googlewalt

Assignees
No one assigned
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ivan-golub @xiemotongye @BalestraPatrick @sgowroji @gregestren @brentleyjones @keertk @keith @bazel-io