Fix documentation for must_keep_debug #18220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
sgowroji
added
team-Rules-CPP
oquenchil
approved these changes
May 5, 2023
oquenchil
added
awaiting-PR-merge
|
@jvolkman, As this PR is approved for merge, could you please fix these buildkite error? Thanks! |
The logic in the documentation was reversed. Setting the flag to `False` (opposite of the default) exposes the `strip_debug_symbols` variable.
jvolkman
force-pushed
the
jvolkman-must_keep_debug
branch
from
15b4723
to
ce11260
Compare
All green now @Pavank1992 |
Pavank1992
removed
the
awaiting-PR-merge
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
The logic in the documentation was reversed. Setting the flag to `False` (opposite of the default) exposes the `strip_debug_symbols` variable. Fixes bazelbuild#14322 Closes bazelbuild#18220. PiperOrigin-RevId: 532039110 Change-Id: Ic58b8a5a139ca43cae8a0eacb2d6b1f97fd669bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in the documentation was reversed. Setting the flag to
False(opposite of the default) exposes thestrip_debug_symbolsvariable.Fixes #14322