Adding support for Linux s390x #1891
Conversation
|
Can one of the admins verify this patch? |
|
We have added support for Linux s390x platform in Bazel. Below note needs to be added in Readme: Compiling Bazel from source on s390x platform:For building Bazel on s390x platform, Protobuf and gRPC-java executable are needed.
Could you please review changes? |
| @@ -128,6 +128,24 @@ inline Atomic64 NoBarrier_CompareAndSwap(volatile Atomic64* ptr, | |||
| return old_value; | |||
| } | |||
|
|
|||
| inline Atomic64 NoBarrier_AtomicIncrement(volatile Atomic64* ptr, | |||
There was a problem hiding this comment.
We intend third_party/protobuf/<version> to be the exact copy of protobuf's directory (see https://github.com/bazelbuild/bazel/blob/master/third_party/protobuf/README.md). So these files should not be changed as part of ths PR
| @@ -128,6 +128,24 @@ inline Atomic64 NoBarrier_CompareAndSwap(volatile Atomic64* ptr, | |||
| return old_value; | |||
| } | |||
|
|
|||
| inline Atomic64 NoBarrier_AtomicIncrement(volatile Atomic64* ptr, | |||
There was a problem hiding this comment.
@dslomov We have reverted changes from above two files.
There was a problem hiding this comment.
We have also updated the documentation for s390x users.
Reverted changes
Updated README to add the proto compiler for Linux s390x.
Updating README to add gRPC Java plugin for Linux s390x.
We have added support for Linux s390x platform in Bazel.