Add bazel mod dump_repo_mapping
#18990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
dump-repo-mapping
branch
2 times, most recently
from
c9ec791
to
07b70b9
Compare
Wyverald
reviewed
Jul 20, 2023
|
|
||
| public static void dumpRepoMapping(BazelDepGraphValue depGraphValue, Writer writer) { | ||
| try (JsonWriter jsonWriter = new JsonWriter(writer)) { | ||
| jsonWriter.beginObject(); |
There was a problem hiding this comment.
overall looks good! just one minor thing -- IMO JsonWriter is a bit too low-level for this; using JsonObject, JsonArray etc would be much more readable (and I doubt memory usage of bazel mod dump_repo_mapping is of any concern). See JsonOutputFormatter for an example.
|
Superseded by #20686 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.