Ensure runfiles output manifest is gone before making it a link. #19382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 0763dd0, the test included in this CL fails like this:
This is because
FileSystemUtils.copyFile
ensured that the target was removed before writing to the target whilePath.createSymbolicLink
does not. Insert adelete()
call to fix the problem.Also, rename
copyManifest
tolinkManifest
for accuracy.