[7.0.0] Write the action digest to the execution log also for cache misses. #19984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, introduce a getter/setter pair to store the digest in the SpawnExecutionContext when looking up the disk or remote cache, and retrieve it later when constructing the SpawnResult. Fixes bazelbuild#16741. PiperOrigin-RevId: 577799982 Change-Id: I570db74f4dbeee95e00853883eda68b25a84934c
bazel-io
added
team-Remote-Exec
github-actions
bot
added
team-Local-Exec
iancha1992
removed
team-Performance
tjgq
approved these changes
Oct 30, 2023
github-actions
bot
removed
the
awaiting-review
tjgq
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, introduce a getter/setter pair to store the digest in the SpawnExecutionContext when looking up the disk or remote cache, and retrieve it later when constructing the SpawnResult.
Fixes #16741.
Commit 40d6780
PiperOrigin-RevId: 577799982
Change-Id: I570db74f4dbeee95e00853883eda68b25a84934c