chore: Ignore shellcheck error in copy-paste code #22530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This piece of code is supposed to be copy-pasted literally, so it is better to already configure shellcheck ignore to help users who apply shellcheck to their scripts.
github-actions
bot
added
the
awaiting-review
fmeum
reviewed
May 24, 2024
| @@ -70,6 +70,7 @@ | |||
| # # --- begin runfiles.bash initialization v3 --- | |||
| # # Copy-pasted from the Bazel Bash runfiles library v3. | |||
| # set -uo pipefail; set +e; f=bazel_tools/tools/bash/runfiles/runfiles.bash | |||
| # # shellcheck disable=SC1090 | |||
There was a problem hiding this comment.
The docs suggest a different workaround, should we use that instead?
https://www.shellcheck.net/wiki/SC1090
There was a problem hiding this comment.
I tried that but couldn't figure it out how to get it work because the file is part of runfile so depending on how shellcheck is executed, it may not be able to locate it. Having # shellcheck source=/dev/null is pretty much the same as ignoring.
fmeum
approved these changes
May 24, 2024
meteorcloudy
added
awaiting-PR-merge
meteorcloudy
approved these changes
May 24, 2024
sgowroji
added
the
team-OSS
github-actions
bot
removed
the
awaiting-PR-merge
|
@bazel-io fork 7.3.0 |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jun 10, 2024
This piece of code is supposed to be copy-pasted literally, so it is better to already configure shellcheck ignore to help users who apply shellcheck to their scripts. Closes bazelbuild#22530. PiperOrigin-RevId: 641178789 Change-Id: I4ea3629f57e66996fca5768cea73497cda29eb16
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
This piece of code is supposed to be copy-pasted literally, so it is better to already configure shellcheck ignore to help users who apply shellcheck to their scripts. Closes #22530. PiperOrigin-RevId: 641178789 Change-Id: I4ea3629f57e66996fca5768cea73497cda29eb16 Commit b75ad88 Co-authored-by: Honnix <honnix@users.noreply.github.com>
|
The changes in this PR have been included in Bazel 7.3.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This piece of code is supposed to be copy-pasted literally, so it is better to already configure shellcheck ignore to help users who apply shellcheck to their scripts.