[7.3.0] C++: Fix versioned shared libraries for macOS #23172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toolchain was passing -l:name. This mechanism doesn' t exist on macOS, instead the full path to the shared library should be passed. To add a proper test like in bazelbuild#20847, this change must first be checked in, the Apple toolchain needs to be updated and then the test can be added. RELNOTES:none PiperOrigin-RevId: 597366229 Change-Id: Ib7cf237cb6c58a69e781197408d3f703010909da
The commit f0ade80 was missing some required changes. The toolchain was passing -l:name. This mechanism doesn' t exist on macOS, instead the full path to the shared library should be passed. To add a proper test like in bazelbuild#20847, this change must first be checked in, the Apple toolchain needs to be updated and then the test can be added. RELNOTES:none PiperOrigin-RevId: 597810345 Change-Id: Ic88feaabdde05143ab145e997de1ef9487af83fd
github-actions
bot
added
awaiting-review
iancha1992
changed the title
|
Unless this is a critical/vulnerability fix, we won't merge this to |
|
@iancha1992 can we repurpose #23165 for 7.4 so we don't miss it? |
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toolchain was passing -l:name. This mechanism doesn' t exist on macOS,
instead the full path to the shared library should be passed.
This is a cherry pick of f0ade80 and eb50e5b