Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change error on adding a directory to the remote cache to be non-fatal #3984

Closed
wants to merge 1 commit into from
Closed

Change error on adding a directory to the remote cache to be non-fatal #3984

wants to merge 1 commit into from

Conversation

mterring
Copy link

While this doesn't implement directory support requested in #3891 it does allow the build to continue and succeed by skipping cache checks for directories.

@bazel-io
Copy link
Member

Can one of the admins verify this patch?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@mterring
Copy link
Author

We've signed the company CLA and I'm a member of our group with my secondary github email (as in the commit).

@rahul-malik
Copy link
Contributor

@mterring - I think this is a fantastic solution for now. IMO - The cache is a benefit to a build but it shouldn't be a hard requirement that all actions must be cached.

@buchgr - Thoughts on this PR?

@katre katre requested a review from ulfjack October 31, 2017 19:33
@katre katre added platform: other P2 We'll consider working on this in future. (Assignee optional) labels Oct 31, 2017
@ulfjack
Copy link
Contributor

ulfjack commented Oct 31, 2017

shrug I don't have any objections to this change. But we first have to convince googlebot that you've signed the CLA.

@ulfjack
Copy link
Contributor

ulfjack commented Oct 31, 2017

I don't see HappyCo in the list of company CLA signers yet, but it says that it may take a few days to process (did you sign it recently?).

@mterring
Copy link
Author

We signed last Friday, so hopefully it's just processing

@ulfjack
Copy link
Contributor

ulfjack commented Nov 28, 2017

I'm afraid I still don't see HappyCo in the list.

@rahul-malik
Copy link
Contributor

@ulfjack - happy to resubmit this patch if CLA is the only thing preventing this from merging

@ulfjack
Copy link
Contributor

ulfjack commented Nov 28, 2017

The CLA is the only problem.

@rahul-malik rahul-malik mentioned this pull request Nov 29, 2017
Closed
@rahul-malik
Copy link
Contributor

@ulfjack @mterring - I've created a new PR here to get past CLA #4188

@mterring
Copy link
Author

Thanks @rahul-malik

bazel-io pushed a commit that referenced this pull request Nov 29, 2017
@rahul-malik
Change error on adding a directory to the remote cache to be non-fatal
71fc9c6 
@ulfjack @buchgr  - I'm resubmitting #3984 on behalf of @mterring to get past CLA issues that are holding it up from merging.

This is a temporary fix for the issue #3891 while we wait for #4011 to be reviewed and tested

Closes #4188.

PiperOrigin-RevId: 177276751
@ulfjack ulfjack closed this Nov 29, 2017
ochafik pushed a commit to ochafik/bazel that referenced this pull request Nov 29, 2017
@rahul-malik @ochafik
Change error on adding a directory to the remote cache to be non-fatal
e02f60d 
@ulfjack @buchgr  - I'm resubmitting bazelbuild#3984 on behalf of @mterring to get past CLA issues that are holding it up from merging.

This is a temporary fix for the issue bazelbuild#3891 while we wait for bazelbuild#4011 to be reviewed and tested

Closes bazelbuild#4188.

PiperOrigin-RevId: 177276751
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this pull request Sep 4, 2022
Change error on adding a directory to the remote cache to be non-fatal
4902e6d 
    @ulfjack @buchgr  - I'm resubmitting bazelbuild/bazel#3984 on behalf of @mterring to get past CLA issues that are holding it up from merging.

    This is a temporary fix for the issue bazelbuild/bazel#3891 while we wait for bazelbuild/bazel#4011 to be reviewed and tested

    Closes #4188.

    PiperOrigin-RevId: 177276751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulfjack ulfjack Awaiting requested review from ulfjack

Assignees

@ulfjack ulfjack

Labels
cla: no P2 We'll consider working on this in future. (Assignee optional) platform: other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mterring @bazel-io @googlebot @rahul-malik @ulfjack @katre