Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64 embedded JDK config, MacOS mock toolchain settings #5525

Closed
wants to merge 4 commits into from

Conversation

ArielleA
Copy link
Contributor

@ArielleA ArielleA commented Jul 6, 2018

Hi,

This PR is for additional work to get the tests running correctly on Aarch64. One key issue was that the default embedded jvm used by default was X86_64 and does not work on other architectures.
To support this I have added a new constraint, however I will refine this in case a version of Darwin becomes available on aarch64.

I'll do the work to find a good arm32 toolchain in a future CL. I do not have access for ppc or z390 to repair those architectures.

Either way, hope this is good for you.

The other non-intel platforms will no longer test nor build properly due to the embedded jdk. I have added a constraint for aarch64, I'll get my arm32 system back up and running to fix that up. Sorry I don't have access to PPC or Z machines.
For the JDK I used Linaro, as Azul Zulu is only jdk8 which doesn't support the nio settings.
@hlopko
Copy link
Member

hlopko commented Jul 10, 2018

LGTM, thanks!

@philwo
Copy link
Member

philwo commented Jul 10, 2018

Hi @ArielleA,

for compliance reasons we need to be able to re-mirror the source code used to build the embedded JVM. Where can we find the source-code for the linked Linaro OpenJDK build? :)

Cheers,
Philipp

@ArielleA
Copy link
Contributor Author

Hi @philwo,

Totally understand that policy, the sourcecode is at openjdk.linaro.org. For the exact jdk in use in the Workspace the url is openjdk.linaro.org/releases/jdk9-src-1708.tar.xz.

Thanks

Arielle :)

@philwo
Copy link
Member

philwo commented Jul 11, 2018

Thanks, that's perfect! I'll add a comment to our release workflow and make sure that we mirror the code when we bump the OpenJDK version. :)

@buchgr
Copy link
Contributor

buchgr commented Jul 24, 2018

Coming from #5661. I think it's great that we want to support aarch64, but I also think that we should have a testing strategy for it.

@philwo
Copy link
Member

philwo commented Jul 25, 2018

@buchgr We'd need some powerful ARM64 machines for our CI lab...

Maybe these https://www.avantek.co.uk/store/avantek-thunderx2-arm-workstation-thunderx2station.html or the Gigabyte ThunderXStation: http://thunderxforums.com/tx2home/viewtopic.php?t=3 ?

@buchgr
Copy link
Contributor

buchgr commented Jul 25, 2018

@philwo 😄 ... sgtm!

@philwo
Copy link
Member

philwo commented Jul 25, 2018

I'm importing this change now. @dslomov told me that we had some agreement with @ArielleA on a mail thread that we'll merge this, but can't / won't officially support arm64 (e.g. with testing or official Bazel releases) until it gains more adoption.

@philwo
Copy link
Member

philwo commented Jul 27, 2018

@ArielleA Just FYI, I have to fix an internal test first, before I can submit it, but it's some C++ related stuff that I don't know much about... I've asked a colleague for help and we'll do this together on Monday, when he is back in the office. Sorry for the delay!

@bazel-io bazel-io closed this in fa7e49f Jul 31, 2018
werkt pushed a commit to werkt/bazel that referenced this pull request Aug 2, 2018
Hi,

This PR is for additional work to get the tests running correctly on Aarch64. One key issue was that the default embedded jvm used by default was X86_64 and does not work on other architectures.
To support this I have added a new constraint, however I will refine this in case a version of Darwin becomes available on aarch64.

I'll do the work to find a good arm32 toolchain in a future CL. I do not have access for ppc or z390 to repair those architectures.

Either way, hope this is good for you.

Closes bazelbuild#5525.

PiperOrigin-RevId: 206717726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants