Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the native headers jar in java_common.compile. #5662

Closed
wants to merge 1 commit into from

Conversation

iirina
Copy link
Contributor

@iirina iirina commented Jul 24, 2018

RELNOTES: java_common.compile creates the native headers jar accesible via JavaInfo.outputs.native_headers.

RELNOTES: java_common.compile creates the native headers jar accesible via JavaInfo.outputs.native_headers.
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@iirina iirina requested a review from dbabkin July 24, 2018 14:19
@iirina
Copy link
Contributor Author

iirina commented Jul 24, 2018

I am the PR author.

@bazel-io bazel-io closed this in ff0c491 Jul 24, 2018
werkt pushed a commit to werkt/bazel that referenced this pull request Aug 2, 2018
RELNOTES: java_common.compile creates the native headers jar accesible via JavaInfo.outputs.native_headers.

Closes bazelbuild#5662.

PiperOrigin-RevId: 205832180
@philwo philwo deleted the irina-native-headers branch January 14, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants