Windows,tests: port startup_options_tests #5706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
//src/test/shell/integration:startup_options_tests now runs on Windows. See bazelbuild#4292 Change-Id: I255b227f7b6b788f21b45b743e7065a646252a36
Running with --nobatch then --batch ensures the second run kills the first one (because of changed startup flags) and the second one too (because of --batch). The `kill` assertions in lines bazelbuild#66 and bazelbuild#67 now succeed. Change-Id: Ibee4997783a820858fc2d2bdda02082a91385d0e
werkt
pushed a commit
to werkt/bazel
that referenced
this pull request
Aug 2, 2018
//src/test/shell/integration:startup_options_tests now runs on Windows. See bazelbuild#4292 Change-Id: I255b227f7b6b788f21b45b743e7065a646252a36 Closes bazelbuild#5706. Change-Id: Ibee4997783a820858fc2d2bdda02082a91385d0e PiperOrigin-RevId: 206551029
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//src/test/shell/integration:startup_options_tests
now runs on Windows.
See #4292
Change-Id: I255b227f7b6b788f21b45b743e7065a646252a36