testenv.sh: do not run "bazel info" unnecessarily #5707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testenv.sh no longer runs "bazel info bazel-bin" and "bazel info bazel-genfiles", because the only test that needs this information is bazel_sandboxing_test.sh This saves 1-2 seconds on Windows in every shell test setup. Also, on Windows we can safely run Bazel in a subshell since bazelbuild#3148 is fixed. Change-Id: If9873221d536f1acfd4849afbfc83b94311de2bd
Change-Id: I04e37c4d5f794017a6050253d8d1b8a8ac43a6d1
Change-Id: I3425050ebd629388e310cd8fdbe84ac41651a59f
werkt
pushed a commit
to werkt/bazel
that referenced
this pull request
Aug 2, 2018
testenv.sh no longer runs "bazel info bazel-bin" and "bazel info bazel-genfiles", because the only test that needs this information is bazel_sandboxing_test.sh This saves 1-2 seconds on Windows in every shell test setup. Also, on Windows we can safely run Bazel in a subshell since bazelbuild#3148 is fixed. Change-Id: If9873221d536f1acfd4849afbfc83b94311de2bd Closes bazelbuild#5707. Change-Id: I04e37c4d5f794017a6050253d8d1b8a8ac43a6d1 PiperOrigin-RevId: 206714921
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testenv.sh no longer runs "bazel info bazel-bin"
and "bazel info bazel-genfiles", because the only
test that needs this information is
bazel_sandboxing_test.sh
This saves 1-2 seconds on Windows in every shell
test setup.
Also, on Windows we can safely run Bazel in a
subshell since #3148 is fixed.
Change-Id: If9873221d536f1acfd4849afbfc83b94311de2bd