Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[singlejar] Use Bazel runfiles lib in test and other Windows fixes #6251

Closed
wants to merge 8 commits into from
Closed

[singlejar] Use Bazel runfiles lib in test and other Windows fixes #6251

wants to merge 8 commits into from

Conversation

rongjiecomputer
Copy link
Contributor

See #2241

@rongjiecomputer
Copy link
Contributor Author

This PR depends on #6248.

@iirina iirina added the area-Windows Windows-specific issues and feature requests label Sep 26, 2018
@rongjiecomputer rongjiecomputer mentioned this pull request Sep 27, 2018
Closed
@laszlocsomor
Copy link
Contributor

Sorry for the delay. Internal review of #6248 is still going, and this PR is blocked on that.

This was referenced Oct 4, 2018
Closed
Closed
@rongjiecomputer
Copy link
Contributor Author

This PR is ready for review.

I still need to use Runfiles library to resolve jar.exe path because Windows tests run in runfiles folder unlike other Unix platforms, so relative path is broken (realpath or blaze_util::MakeAbsolute won't work).

@rongjiecomputer
Copy link
Contributor Author

@laszlocsomor Rebased and removed some no_windows (except desugar_checking_test). PTAL.

@laszlocsomor
Copy link
Contributor

laszlocsomor commented Nov 2, 2018 •
edited
Loading

FYI, regardless of my comments, tests now pass at 4d4562e. Yaaay!

C:\src\bazel>bazel test //src/tools/singlejar:all_windows_tests
INFO: Analysed 11 targets (0 packages loaded).
INFO: Found 11 test targets...
INFO: Elapsed time: 280.441s, Critical Path: 279.68s
INFO: 1 process: 1 local.
INFO: Build completed successfully, 2 total actions
//src/tools/singlejar:combiners_test                            (cached) PASSED in 147.6s
//src/tools/singlejar:input_jar_bad_jar_test                    (cached) PASSED in 16.9s
//src/tools/singlejar:input_jar_empty_jar_test                  (cached) PASSED in 26.9s
//src/tools/singlejar:input_jar_preambled_test                  (cached) PASSED in 244.5s
//src/tools/singlejar:options_test                              (cached) PASSED in 26.1s
//src/tools/singlejar:output_jar_bash_test                      (cached) PASSED in 113.4s
//src/tools/singlejar:output_jar_simple_test                    (cached) PASSED in 156.5s
//src/tools/singlejar:token_stream_test                         (cached) PASSED in 26.1s
//src/tools/singlejar:zip_headers_test                          (cached) PASSED in 25.1s
//src/tools/singlejar:zlib_interface_test                       (cached) PASSED in 16.9s
//src/tools/singlejar:zip64_test                                         PASSED in 229.9s

Executed 1 out of 11 tests: 11 tests pass.
INFO: Build completed successfully, 2 total actions

@rongjiecomputer
Copy link
Contributor Author

When BuildKite uses Bazel 0.18.1 (released a few days ago), we can enable desugar_checking_test and singlejar itself on Windows!

@meteorcloudy
Copy link
Member

I'll ask our CI master to upgrade bazel when he comes back!

@bazel-io bazel-io closed this in 4b53e8f Nov 2, 2018
@meteorcloudy
Copy link
Member

@philwo Can we upgrade Bazel to 0.19.0 on our CI?

@meteorcloudy
Copy link
Member

@rongjiecomputer Thanks to Phillipp, Bazel has been upgraded to 0.19.0 on CI!

@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laszlocsomor laszlocsomor laszlocsomor left review comments

Assignees
No one assigned
Labels
area-Windows Windows-specific issues and feature requests cla: yes team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rongjiecomputer @laszlocsomor @meteorcloudy @philwo @iirina @googlebot