Dont break long words for debian control fields #777
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default wrapping can split on `-` characters which creates the chance that any dependency with a `-` in it that falls near the wrap threshold will get split along two lines and render the control file invalid. > Text is preferably wrapped on whitespaces and right after the hyphens > in hyphenated words; only then will long words be broken if necessary, > unless TextWrapper.break_long_words is set to false. https://docs.python.org/3.1/library/textwrap.html#textwrap.TextWrapper.break_long_words
|
LGTM importing. Thanks again for baring with me :) |
|
@damienmg no problem, it was my pleasure. |
bazel-io
pushed a commit
that referenced
this pull request
Jan 12, 2016
By default wrapping can split on `-` characters which creates the chance that any dependency with a `-` in it that falls near the wrap threshold will get split along two lines and render the control file invalid. > Text is preferably wrapped on whitespaces and right after the hyphens > in hyphenated words; only then will long words be broken if necessary, > unless TextWrapper.break_long_words is set to false. https://docs.python.org/3.1/library/textwrap.html#textwrap.TextWrapper.break_long_words Fixes #772. -- Reviewed-on: #777 MOS_MIGRATED_REVID=111925490
|
This has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default wrapping can split on
-characters which creates the chance that anydependency with a
-in it that falls near the wrap threshold will getsplit along two lines and render the control file invalid.
This supersede #773 and closes #772