Fix include for the cpp example on the website #787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The precedent commit of this file fix the same problem for the compilation of Gtest, this one correct the same issue (headers are in the /include directory) for the Google Test example. Fix issue : https://groups.google.com/forum/#!topic/bazel-discuss/xPe-oaqWZ6s
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
LGTM, importing |
bazel-io
pushed a commit
that referenced
this pull request
Jan 14, 2016
See https://groups.google.com/forum/#!topic/bazel-discuss/xPe-oaqWZ6s -- Reviewed-on: #787 MOS_MIGRATED_REVID=112129205
|
LGTM2 |
|
This was merged :) |
steren
pushed a commit
to bazelbuild/bazel-website
that referenced
this pull request
Apr 26, 2017
See https://groups.google.com/forum/#!topic/bazel-discuss/xPe-oaqWZ6s -- Reviewed-on: bazelbuild/bazel#787 MOS_MIGRATED_REVID=112129205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The precedent commit of this file fix the same problem for the compilation of Gtest, this one correct the same issue (headers are in the /include directory) for the Google Test example.
Fix issue : https://groups.google.com/forum/#!topic/bazel-discuss/xPe-oaqWZ6s