-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add repo rule for fetching a Python SDK #8265
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
As much as I love seeing this, would it maybe make more sense to have this in an external repository? https://github.com/bazelbuild/rules_python/ has not received much love recently but imo it would probably be the best place for this to have fixes/updates to this repo rule independent of bazel releases. WDYT? |
Hi @Globegitter What do you think, @brandjon Could you please also clarify my doubts above related testing |
Also quite interesting project that has a standalone python for windows: https://github.com/indygreg/python-build-standalone - though I have not tested it yet. |
@Globegitter thank you for your sharing! |
ctx.report_progress("Configure") | ||
res = ctx.execute([ | ||
"./configure", | ||
"--prefix=" + str(ctx.path("./")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want something like --enable-optimizations
here too?
Perhaps this should be reopened in rules_python? |
Right, this should definitely be reopened in rules_python. I'll transfer the underlying issue. |
Closing this for now - please reopen a new PR in the rules_python repository. |
FWIW I ran into this problem and saw it wasn't solved so I just recently published some rules that leverage pyenv to download, compile and register the python toolchain with whatever It's probably a little rough but feedback and PRs are welcome; I just hope what's currently there can help some folks. 😉 🍻 |
Backbone for https://github.com/bazelbuild/bazel/issues/7467
Restarting
afterInstall
phase, what can be the cause?