Wrap Stardoc signature summaries #9240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes |
c-parsons
requested changes
Aug 26, 2019
src/main/java/com/google/devtools/build/skydoc/rendering/MarkdownUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/skydoc/rendering/MarkdownUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/skydoc/rendering/MarkdownUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/skydoc/rendering/MarkdownUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/skydoc/rendering/MarkdownUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/skydoc/rendering/MarkdownUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/skydoc/rendering/MarkdownUtil.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/devtools/build/skydoc/testdata/struct_default_value_test/golden.txt
Show resolved
Hide resolved
|
Can see progress |
|
I think all concerns have been addressed. |
c-parsons
approved these changes
Sep 13, 2019
|
Nice, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid long lines that require excessive horizontal scrolling, signature summaries should be wrapped. The corresponding Stardoc issue is bazelbuild/skydoc#142