Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow escaped linebreaks in buildozer command arguments #778

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

vladmos
Copy link
Member

@vladmos vladmos commented Feb 3, 2020

#773 allows buildozer arguments to be separated by linebreaks. However in some cases it's required to have linebreaks inside arguments (e.g. for adding multiline comments), in such cases it should be allowed to use escaped linebreaks, such as:

$ buildozer 'comment srcs a.cc Just\ a\
multiline\ comment' //my:package

Copy link
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test?

@vladmos
Copy link
Member Author

vladmos commented Feb 3, 2020

It exists but currently it's internal. I'll try to opensource buildozer tests soon.

Copy link
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

but please open-source the tests soon

@vladmos
Copy link
Member Author

vladmos commented Feb 4, 2020

will do

@vladmos vladmos merged commit 9e63c6f into bazelbuild:master Feb 4, 2020
@vladmos vladmos deleted the multiline_comment branch February 4, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants