Install Android NDK r25b #1434
Merged
Install Android NDK r25b #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ahumesky |
Wyverald
approved these changes
Sep 13, 2022
|
thank you! |
|
Can we do this for macOS as well? continuous-integration/macos/mac-android.sh Lines 5 to 9 in b4afc8c |
|
Yes, we should. But for macOS, upgrading involves a lot of manually work (we maintain our own physical machines), the team is currently overwhelmed by all kinds of CI issue. Can you file an issue to track this so that we don't forget? And yes, I haven't forgot #1273 (comment), I already upgraded two machines in the testing environment, but some Bazel tests are failing due to the removal of |
fmeum
pushed a commit
to fmeum/continuous-integration
that referenced
this pull request
Dec 10, 2023
* Install Android NDK r25b * Mount android ndk r25b to docker container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by rules_android_ndk, still keeping the old one since legacy rules may need it.