Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Logger.assertTrue in CommandLineTask #6619

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

LeFrosch
Copy link
Collaborator

@LeFrosch LeFrosch commented Aug 7, 2024

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number:

Description of this change

These assertions should not cause a failure in production. However, java assertions seem to enabled in production.

@LeFrosch LeFrosch marked this pull request as ready for review August 7, 2024 09:23
@github-actions github-actions bot added the awaiting-review Awaiting review from Bazel team on PRs label Aug 7, 2024
@LeFrosch LeFrosch requested a review from ujohnny August 7, 2024 09:24
@tpasternak tpasternak merged commit e0024d8 into bazelbuild:master Aug 7, 2024
8 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Aug 7, 2024
kitbuilder587 pushed a commit to kitbuilder587/intellij that referenced this pull request Aug 8, 2024
mai93 pushed a commit that referenced this pull request Aug 8, 2024
@LeFrosch LeFrosch deleted the Daniel.Brauner/assertions branch September 19, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants