Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to generate release notes & .zip files #78

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

keertk
Copy link
Member

@keertk keertk commented Aug 30, 2023

Part of automating the java_tools release process (bazelbuild/continuous-integration#1733)

@keertk keertk marked this pull request as ready for review August 30, 2023 01:00
@keertk keertk requested a review from hvadehra August 30, 2023 01:01
meteorcloudy pushed a commit to bazelbuild/continuous-integration that referenced this pull request Aug 30, 2023
Script: bazelbuild/java_tools#78

(This is just the part that creates the release on GitHub. Steps to
create RCs, update files, create PRs, etc. are still in progress).

cc @hvadehra
@hvadehra
Copy link
Member

Have you considered changing the output of create_java_tools_release.sh to make it automation-friendly? (the output from that script was only ever for human consumption, so changing it won't break anything.)

I think making that script dump json with all the values you need here would be easier to maintain that the complex and somewhat brittle parsing in this PR.

@keertk
Copy link
Member Author

keertk commented Aug 30, 2023

Oh that's good to know! I wasn't sure if that script was being used elsewhere.
I'll take a look and update, thanks!

@hvadehra
Copy link
Member

btw, outputting json was just me thinking out loud. It would definitely be trivial to parse in python. But please feel free to use whatever standard format (maybe yaml?) is easiest in shell. I'm pretty sure there's a package for everything in python :)

scripts/release.py Outdated Show resolved Hide resolved
scripts/release.py Show resolved Hide resolved
@keertk keertk merged commit 8edd0a7 into bazelbuild:master Oct 2, 2023
1 check passed
fmeum pushed a commit to fmeum/continuous-integration that referenced this pull request Dec 10, 2023
Script: bazelbuild/java_tools#78

(This is just the part that creates the release on GitHub. Steps to
create RCs, update files, create PRs, etc. are still in progress).

cc @hvadehra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants