Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a round robin grpc balancer #554

Merged
merged 2 commits into from
May 1, 2024
Merged

add a round robin grpc balancer #554

merged 2 commits into from
May 1, 2024

Commits on May 1, 2024

  1. add a round robin grpc balancer 

    This replaces the current load balancer which was copied over from the
gcp repo which uses experimental APIs from grpc-go.

Depending on experimental APIs marks the SDK as experimental as well.
It also complicates importing the SDK to google3 where everything must
be compatbile at head.

This major difference between this simple implementation and the
existing one is the maximum number of streams allowed on a single
connection.
The existing balancer limits streams to 3 by default and allows
configuring that limit.
The new simpler implementation does not enforce any limit.

I have tested the simple balancer by building chromium and android with
and without it enabled. I observed no difference in build latency.
    @mrahs
    mrahs committed May 1, 2024
    Configuration menu
    Copy the full SHA
    1052ee6 View commit details
    Browse the repository at this point in the history

  2. add a round robin grpc balancer 

    This replaces the current load balancer which was copied over from
the gcp repo which uses experimental APIs from grpc-go.

Depending on experimental APIs marks the SDK as experimental as well.
It also complicates importing the SDK to google3 where everything
must be compatbile at head.

This major difference between this simple implementation and the existing
one is the maximum number of streams allowed on a single connection.
The existing balancer limits streams to 3 by default and allows
configuring that limit. The new simpler implementation
does not enforce any limit.

I have tested the simple balancer by building chromium and android
with and without it enabled. I observed no difference in build latency.
    @mrahs
    mrahs committed May 1, 2024
    Configuration menu
    Copy the full SHA
    ca01955 View commit details
    Browse the repository at this point in the history