Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire Travis in favor of Buildkite #422

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Sep 14, 2019

This PR retires Travis in favor of Buildkite.

@Yannic
Copy link
Contributor Author

Yannic commented Sep 16, 2019

Seems like Bazelisk is running into GitHub rate limiting on Travis.

//cc @philwo

@philwo
Copy link
Member

philwo commented Sep 16, 2019

@Yannic I can think of three ways to fix this:

@Yannic
Copy link
Contributor Author

Yannic commented Sep 16, 2019

I'm voting for removing Travis. It's slow and doesn't provide anything we can't get from Buildkite.

@gkdn @dslomov @laurentlb WDYT?

@alexeagle
Copy link
Contributor

Sounds great @Yannic

Can you check that all the tests run on Travis are also run on buildkite, so we know we don't lose any coverage? And update the PR to just remove the travis config.

@Yannic
Copy link
Contributor Author

Yannic commented Oct 2, 2019

We're running the same tests on Buildkite as we run on Travis (//...), and, IIUC, sandboxing is the default these days.

Someone with write (or even admin) access needs to remove that Travis is a required check for PRs before we can delete the config. @dslomov @laurentlb Can one of you handle this?

@philwo
Copy link
Member

philwo commented Oct 2, 2019

@Yannic Done :)

@Yannic Yannic changed the title [travis] Switch to Bazelisk Retire Travis in favor of Buildkite Oct 10, 2019
@Yannic
Copy link
Contributor Author

Yannic commented Oct 10, 2019

@alexeagle Done. ptal

We now test exclusively on BuildKite which is maintained by Bazel team
@alexeagle alexeagle merged commit 7b43c90 into bazelbuild:master Oct 11, 2019
sgammon pushed a commit to Bloombox/rules_closure that referenced this pull request Oct 17, 2019
We now test exclusively on BuildKite which is maintained by Bazel team
mbrukman added a commit to mbrukman/bazelbuild-rules_closure that referenced this pull request Apr 16, 2022
The `.travis.yml` config was [removed in 2019][1] with the message:

> ### Delete .travis.yml (bazelbuild#422)
>
> We now test exclusively on BuildKite which is maintained by Bazel team

[1]: bazelbuild@7b43c90
mbrukman added a commit to mbrukman/bazelbuild-rules_closure that referenced this pull request Apr 16, 2022
The `.travis.yml` config was [removed in 2019][1] with the message:

> ### Delete .travis.yml (bazelbuild#422)
>
> We now test exclusively on BuildKite which is maintained by Bazel team

Since we are not modifying any code, we can [skip ci].

[1]: bazelbuild@7b43c90
mbrukman added a commit to mbrukman/bazelbuild-rules_closure that referenced this pull request Apr 19, 2022
The `.travis.yml` config was [removed in 2019][1] with the message:

> ### Delete .travis.yml (bazelbuild#422)
>
> We now test exclusively on BuildKite which is maintained by Bazel team

Since we are not modifying any code, we can [skip ci].

[1]: bazelbuild@7b43c90
gkdn pushed a commit that referenced this pull request Apr 19, 2022
The `.travis.yml` config was [removed in 2019][1] with the message:

> ### Delete .travis.yml (#422)
>
> We now test exclusively on BuildKite which is maintained by Bazel team

Since we are not modifying any code, we can [skip ci].

[1]: 7b43c90
ptmphuong pushed a commit to ptmphuong/rules_closure that referenced this pull request Dec 9, 2022
We now test exclusively on BuildKite which is maintained by Bazel team
ptmphuong pushed a commit to ptmphuong/rules_closure that referenced this pull request Dec 9, 2022
The `.travis.yml` config was [removed in 2019][1] with the message:

> ### Delete .travis.yml (bazelbuild#422)
>
> We now test exclusively on BuildKite which is maintained by Bazel team

Since we are not modifying any code, we can [skip ci].

[1]: bazelbuild@7b43c90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants