Remove deprecated Python Closure Linter

README.md

@@ -6,7 +6,6 @@ JavaScript | Templating | Stylesheets
 [closure_js_binary](#closure_js_binary) | [closure_template_java_library](#closure_template_java_library) | [closure_css_binary](#closure_css_binary)
 [closure_js_deps](#closure_js_deps) | [closure_template_py_library](#closure_template_py_library) |
 [closure_js_test](#closure_js_test) | |
-[closure_js_lint_test](#closure_js_lint_test) | |
 [closure_js_check_test](#closure_js_check_test) | |
 
 ## Overview
@@ -43,7 +42,6 @@ The Closure Rules bundle the following tools and makes them "just work."
 - [Closure Stylesheets][closure-stylesheets]: CSS compiler supporting class name
   minification, variables, functions, conditionals, mixins, and bidirectional
   layout.
-- [Closure Linter][closure-linter]: Automated style checker and fixer.
 - [PhantomJS][phantomjs]: Headless web browser used for automating JavaScript
   unit tests in a command line environment.
 - [Bazel][bazel]: The build system Google uses to manage a repository with
@@ -402,47 +400,6 @@ path.
   documentation for more information.
 
 
-## closure\_js\_lint\_test
-
-```python
-load("@io_bazel_rules_closure//closure:defs.bzl", "closure_js_lint_test")
-closure_js_check_test(name, srcs, errors, defs)
-```
-
-Tests JavaScript sources for conformance to [Google JavaScript Style][jsstyle]
-and Google Closure Style.
-
-If the sources do not conform, then the error message will show you a command
-you can run to fix your source code.
-
-### Arguments
-
-- **name:** ([Name][name]; required) A unique name for this rule.
-
-- **srcs:** (List of [labels][labels]; required) JavaScript files to check.
-  These can be normal sources or externs files.
-
-- **errors:** (List of strings; optional; default is `["all"]`) Which errors to
-  enable.
-
-  - `all`: Enables all following errors.
-  - `blank_lines_at_top_level`: Validates number of blank lines between blocks
-    at top level.
-  - `indentation`: Checks correct indentation of code.
-  - `well_formed_author`: Validates the `@author` JsDoc tags.
-  - `no_braces_around_inherit_doc`: Forbids braces around `@inheritdoc` JsDoc
-    tags.
-  - `braces_around_type`: Enforces braces around types in JsDoc tags.
-  - `optional_type_marker`: Checks correct use of optional marker = in param
-    types.
-  - `unused_private_members`: Checks for unused private variables.
-  - `unused_local_variables`: Checks for unused local variables.
-
-- **defs:** (List of strings; optional) Additional flags to pass to the gjslint
-  command. Some useful ones are: `--closurized_namespaces=ns1,ns2` and
-  `--ignored_extra_namespaces=goog.testing.asserts`.
-
-
 ## closure\_js\_check\_test
 
 ```python
@@ -767,7 +724,6 @@ The documentation on using Closure Stylesheets can be found
 [blockers]: https://github.com/bazelbuild/rules_closure/labels/launch%20blocker
 [closure-compiler]: https://developers.google.com/closure/compiler/
 [closure-library]: https://developers.google.com/closure/library/
-[closure-linter]: https://developers.google.com/closure/utilities/
 [closure-stylesheets]: https://github.com/google/closure-stylesheets
 [closure-templates]: https://developers.google.com/closure/templates/
 [closure-tools]: https://developers.google.com/closure/

closure/defs.bzl

@@ -17,7 +17,6 @@
 load("//closure/compiler:closure_js_binary.bzl", "closure_js_binary")
 load("//closure/compiler:closure_js_deps.bzl", "closure_js_deps")
 load("//closure/compiler:closure_js_library.bzl", "closure_js_library")
-load("//closure/linter:closure_js_lint_test.bzl", "closure_js_lint_test")
 load("//closure:repositories.bzl", "closure_repositories")
 load("//closure/stylesheets:closure_css_binary.bzl", "closure_css_binary")
 load("//closure/stylesheets:closure_css_library.bzl", "closure_css_library")

closure/library/test/BUILD

@@ -12,7 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-load("//closure/linter:closure_js_lint_test.bzl", "closure_js_lint_test")
 load("//closure/testing:closure_js_test.bzl", "closure_js_test")
 
 closure_js_test(
@@ -24,9 +23,3 @@ closure_js_test(
         "//closure/library:testing",
     ],
 )
-
-closure_js_lint_test(
-    name = "lint",
-    srcs = ["dom_test.js"],
-    visibility = ["//visibility:private"],
-)

closure/repositories.bzl

@@ -76,15 +76,6 @@ def closure_library():
       build_file = str(Label("//closure/library:closure_library.BUILD")),
   )
 
-def closure_linter():
-  native.new_http_archive(
-      name = "closure_linter",
-      url = "https://bazel-mirror.storage.googleapis.com/github.com/google/closure-linter/archive/v2.3.19.zip",
-      sha256 = "ccb93b7327cd1e1520d0090c51f2f11d5174a34df24e1fa4d0114ffff28a7141",
-      strip_prefix = "closure-linter-2.3.19",
-      build_file = str(Label("//closure/linter:closure_linter.BUILD")),
-  )
-
 def closure_stylesheets():
   native.maven_jar(
       name = "closure_stylesheets",
@@ -204,15 +195,6 @@ def phantomjs_macosx():
       url = "https://bazel-mirror.storage.googleapis.com/bitbucket.org/ariya/phantomjs/downloads/phantomjs-2.1.1-macosx.zip",
   )
 
-def python_gflags():
-  native.new_http_archive(
-      name = "python_gflags",
-      url = "https://bazel-mirror.storage.googleapis.com/github.com/google/python-gflags/archive/3.0.2.zip",
-      sha256 = "8700f5b8d61f843425b090287874b4ff45510d858caa109847162dd98c7856f8",
-      strip_prefix = "python-gflags-3.0.2",
-      build_file = str(Label("//closure/linter:python_gflags.BUILD")),
-  )
-
 def soy():
   native.maven_jar(
       name = "soy",
@@ -236,7 +218,6 @@ def closure_repositories(
     omit_args4j=False,
     omit_closure_compiler=False,
     omit_closure_library=False,
-    omit_closure_linter=False,
     omit_closure_stylesheets=False,
     omit_fonts_noto_hinted_deb=False,
     omit_fonts_noto_mono_deb=False,
@@ -254,7 +235,6 @@ def closure_repositories(
     omit_libpng_amd64_deb=False,
     omit_phantomjs_linux_x86_64=False,
     omit_phantomjs_macosx=False,
-    omit_python_gflags=False,
     omit_soy=False,
     omit_soyutils_usegoog=False):
   if not omit_aopalliance:
@@ -273,8 +253,6 @@ def closure_repositories(
     closure_compiler()
   if not omit_closure_library:
     closure_library()
-  if not omit_closure_linter:
-    closure_linter()
   if not omit_closure_stylesheets:
     closure_stylesheets()
   if not omit_fonts_noto_hinted_deb:
@@ -309,8 +287,6 @@ def closure_repositories(
     phantomjs_linux_x86_64()
   if not omit_phantomjs_macosx:
     phantomjs_macosx()
-  if not omit_python_gflags:
-    python_gflags()
   if not omit_soy:
     soy()
   if not omit_soyutils_usegoog: