This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
Add a simple Kubernetes custom controller/resource example. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The OSX issue looks the same as this |
mattmoor
force-pushed
the
controller
branch
2 times, most recently
from
113fd62
to
571d385
Compare
mattmoor
force-pushed
the
controller
branch
4 times, most recently
from
6e45567
to
572ad57
Compare
|
Ok, I expect this is RFAL |
mattmoor
force-pushed
the
controller
branch
2 times, most recently
from
69142a8
to
4262fbb
Compare
dlorenc
reviewed
Oct 13, 2017
| ports: | ||
| - containerPort: 50051 | ||
| env: | ||
| - name: MY_NAMESPACE |
There was a problem hiding this comment.
You can also get this from /var/run/secrets/kubernetes.io/serviceaccount/namespace and avoid using the downward API.
There was a problem hiding this comment.
neat, but I'd rather avoid reading a file :-/
| kind: Todo | ||
| # # shortNames allow shorter string to match your resource on the CLI | ||
| # shortNames: | ||
| # - todo |
| bazel run examples/todocontroller/example-todo.describe | ||
| bazel run examples/todocontroller/${LANGUAGE}:controller-deployment.describe | ||
|
|
||
| bazel build examples/todocontroller/example-todo.delete |
There was a problem hiding this comment.
Why not bazel run everything in here, instead of bazel building then executing?
There was a problem hiding this comment.
I want coverage of separate build/run working :)
This has a handful of components: - a "TODO" Custom Resource Definition (CRD), - a "TODO" example instance, and - a Custom Controller that watches for "TODOs" not marked "done" and completes them with a comment. This also adds a little e2e test that: - Creates the CRD/Controller and starter TODO - Checks the note on the TODO - Updates the Controller (waits) and then the TODO (waits) - Checks the note on the TODO has changed appropriately - Repeat edit/check - Teardown
dlorenc
approved these changes
Oct 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a handful of components:
This also adds a little e2e test that:
Fixes: #30