Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please move from native to Skylark rules for external git/http repositories #74

Closed
aehlig opened this issue Jun 5, 2018 · 2 comments
Closed

Comments

@aehlig
Copy link

aehlig commented Jun 5, 2018

Bazel is planning to move away from native rules for external repositories to Skylark rules, mainly because bundling every version control system in bazel does not scale. As part of this effort, we plan to submit https://bazel-review.googlesource.com/c/bazel/+/55932 soon, which will cause bazel by default to insist that the skylark versions the git and http rules for external repositories be used. This can be disabled by a flag for at least the next 6 months, but we still would appreciate if you could adopt your repository to use the Skylark versions of those rules soon.

A test run of downstream projects with that flag flip in bazel enabled can be found at https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/286

For more background, see

Thanks.

@hsyed
Copy link
Contributor

hsyed commented Jun 11, 2018

Skydoc is the problem for this one. I'll remove skydoc from the repo since it's not actively maintained and we can't generate skydoc anymore anyway. (see #60)

@hsyed
Copy link
Contributor

hsyed commented Jul 4, 2018

Done as far as I can tell.

@hsyed hsyed closed this as completed Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants