Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'experimental_use_abi_jars' toolchain attribute cleanup #733

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oliviernotteghem
Copy link
Contributor

Fixes #732

Copy link
Collaborator

@Bencodes Bencodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm as long as we still have the docs for kt_abi_plugin_incompatible. I think there's one edge case in our codebase that still might be broken, but it's isolated to a single module that has some creative Kotlin in it.

@Bencodes
Copy link
Collaborator

@oliviernotteghem we can land this PR after 1.6 has it's first stable release, which would put this in the 1.7 release.

@Bencodes
Copy link
Collaborator

Alright was chatting with @nkoroste and @cgruber about how to best merge this. The main concern that we still support Kotlin 1.6 which has version of kotlin-abi-gen that are completely broken, so enabling this globally is probably going to cause issues for the people that haven't upgraded yet.

The plan that we came up with is:

  • Drop the top level Kotlin toolchain option and enable experimental_use_abi_jars by default so that more of our users are bucketed into using the abi compiler.
  • Keep the config_setting so that you can still disable kotlin-abi-gen globally using --define=experimental_use_abi_jars=1|0.
  • Keep the kt_abi_plugin_incompatible check so that there are still ways to opt-out at the target level if there are problematic Kotlin files that aren't yet abi-gen compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'kt_abi_plugin_incompatible' should be respected even if 'experimental_use_abi_jars' is False
2 participants