Skip to content

Commit 1ef6704

Browse files
thesayynalexeagle
authored andcommitted
fix: use golden_file_test instead
1 parent 8a3f9b0 commit 1ef6704

File tree

8 files changed

+17
-29
lines changed

8 files changed

+17
-29
lines changed

internal/node/_node_bin/node

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
#!/bin/bash
2+
export NP_PATCHED_NODEJS="/Users/thesayyn/Documents/bazel/rules_nodejs/internal/node/_node_bin"
3+
export PATH="/Users/thesayyn/Documents/bazel/rules_nodejs/internal/node/_node_bin":$PATH
4+
if [[ ! "${@}" =~ "node_patches.js" ]]; then
5+
exec /private/var/tmp/_bazel_thesayyn/a9a36d475d03232bfeced54055fb3183/external/nodejs_darwin_amd64/bin/nodejs/bin/node --require "/Users/thesayyn/Documents/bazel/rules_nodejs/internal/node/node_patches.js" "$@"
6+
else
7+
exec /private/var/tmp/_bazel_thesayyn/a9a36d475d03232bfeced54055fb3183/external/nodejs_darwin_amd64/bin/nodejs/bin/node "$@"
8+
fi
9+
Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,20 @@
11
load("@build_bazel_rules_nodejs//:index.bzl", "pkg_web")
2-
load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
2+
load("//internal/golden_file_test:golden_file_test.bzl", "golden_file_test")
33

44
package(default_visibility = ["//visibility:public"])
55

66
pkg_web(
77
name = "pkg",
88
srcs = [
9-
"index.html",
9+
"index.js",
1010
],
1111
substitutions = {
1212
"THIS_SHOULD_BE_REPLACED": "THIS_SHOULD_BE_REPLACED_WITH_THIS",
1313
},
1414
)
1515

16-
jasmine_node_test(
16+
golden_file_test(
1717
name = "test",
18-
srcs = ["spec.js"],
19-
data = [
20-
"index_golden.html_",
21-
":pkg",
22-
],
23-
tags = [
24-
"fix-windows",
25-
],
18+
actual = ":pkg",
19+
golden = "index_golden.js_",
2620
)

internal/pkg_web/golden_test/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
const a = 'THIS_SHOULD_BE_REPLACED';
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
const a = 'THIS_SHOULD_BE_REPLACED_WITH_THIS';

internal/pkg_web/pkg_web.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ _ATTRS = {
2626
doc = """Files which should be copied into the package""",
2727
),
2828
"substitutions": attr.string_dict(
29-
doc = """Key-value pairs which are replaced in all the files while building the package.""",
29+
doc = """Key-value pairs are replaced in all files while building the package.""",
3030
),
3131
"_assembler": attr.label(
3232
default = "@build_bazel_rules_nodejs//internal/pkg_web:assembler",

internal/pkg_web/test3/index.html

Lines changed: 0 additions & 1 deletion
This file was deleted.

internal/pkg_web/test3/index_golden.html_

Lines changed: 0 additions & 1 deletion
This file was deleted.

internal/pkg_web/test3/spec.js

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)