Skip to content

Commit 30bc86c

Browse files
authored
fix: make generated_file_test .update's visibility same as test rule (#2677)
1 parent 8319dbf commit 30bc86c

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

internal/generated_file_test/generated_file_test.bzl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
load("@build_bazel_rules_nodejs//internal/node:node.bzl", "nodejs_binary", "nodejs_test")
44

5-
def generated_file_test(name, generated, src, substring_search = False, src_dbg = None, **kwargs):
5+
def generated_file_test(name, generated, src, substring_search = False, src_dbg = None, visibility = None, **kwargs):
66
"""Tests that a file generated by Bazel has identical content to a file in the workspace.
77
88
This is useful for testing, where a "snapshot" or "golden" file is checked in,
@@ -16,6 +16,7 @@ def generated_file_test(name, generated, src, substring_search = False, src_dbg
1616
anywhere within the generated file. Note that the .update rule is not generated in substring mode.
1717
src_dbg: if the build uses `--compilation_mode dbg` then some rules will produce different output.
1818
In this case you can specify what the dbg version of the output should look like
19+
visibility: visibility for both test target & update target
1920
**kwargs: extra arguments passed to the underlying nodejs_test
2021
"""
2122
data = [src, generated]
@@ -36,6 +37,7 @@ def generated_file_test(name, generated, src, substring_search = False, src_dbg
3637
loc % generated,
3738
],
3839
data = data,
40+
visibility = visibility,
3941
**kwargs
4042
)
4143

@@ -46,4 +48,5 @@ def generated_file_test(name, generated, src, substring_search = False, src_dbg
4648
entry_point = "@build_bazel_rules_nodejs//internal/generated_file_test:bundle.js",
4749
templated_args = ["--out", loc % src, loc % src_dbg, loc % generated],
4850
data = data,
51+
visibility = visibility,
4952
)

0 commit comments

Comments
 (0)