Skip to content

Commit 30d0f37

Browse files
alan-agius4alexeagle
authored andcommitted
fix: angular example ts_scripts path in Windows
In Windows `_/ts_scripts.js` will be expanded to `C:/Program Files/Git/ts_scripts.js`. ``` [ 'C:\\users\\alag\\_bazel_alag\\rj2iva3m\\external\\build_bazel_rules_nodejs\\internal\\node\\_node_bin\\node', 'C:\\users\\alag\\_bazel_alag\\rj2iva3m\\execroot\\examples_angular\\node_modules\\html-insert-assets\\src\\main.js', '--html=src/example/index.html', '--out=bazel-out/x64_windows-fastbuild/bin/src/index.html', '--roots=.', 'bazel-out/x64_windows-fastbuild/bin/src', '--assets', 'bazel-out/x64_windows-fastbuild/bin/src/styles.css', 'external/npm/node_modules/@angular/material/prebuilt-themes/deeppurple-amber.css', 'external/npm/node_modules/zone.js/dist/zone.min.js', './_C:/Program Files/Git/ts_scripts.js' ] ``` This seems like some character escaping issue but in general escaping is hell and this is a more straightforward fix. Partially addresses: #1604
1 parent db577fa commit 30d0f37

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

examples/angular/src/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ html_insert_assets(
8888
"--assets",
8989
] + ["$(execpath %s)" % s for s in _ASSETS] + [
9090
# This file doesn't exist during the build, but will be served by ts_devserver
91-
"_/ts_scripts.js",
91+
"./_/ts_scripts.js",
9292
],
9393
data = ["//src:example/index.html"] + _ASSETS,
9494
)

examples/angular_view_engine/src/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ html_insert_assets(
9494
"--assets",
9595
] + ["$(execpath %s)" % s for s in _ASSETS] + [
9696
# This file doesn't exist during the build, but will be served by ts_devserver
97-
"_/ts_scripts.js",
97+
"./_/ts_scripts.js",
9898
],
9999
data = ["//src:example/index.html"] + _ASSETS,
100100
)

0 commit comments

Comments
 (0)