feat: add link_workspace_root to nodejs_binary, npm_package_bin, rollup_bundle, terser_minified, ts_project

Link the workspace root to the bin_dir to support absolute requires like 'my_wksp/path/to/file'.
If source files need to be required then they can be copied to the bin_dir with copy_to_bin.

Author: gregmagolan

internal/linker/link_node_modules.bzl

@@ -56,16 +56,18 @@ def _link_mapping(label, mappings, k, v):
     else:
         return True
 
-def write_node_modules_manifest(ctx, extra_data = [], mnemonic = None):
+def write_node_modules_manifest(ctx, extra_data = [], mnemonic = None, link_workspace_root = False):
     """Writes a manifest file read by the linker, containing info about resolving runtime dependencies
 
     Args:
         ctx: starlark rule execution context
         extra_data: labels to search for npm packages that need to be linked (ctx.attr.deps and ctx.attr.data will always be searched)
         mnemonic: optional action mnemonic, used to differentiate module mapping files from the same rule context
+        link_workspace_root: Link the workspace root to the bin_dir to support absolute requires like 'my_wksp/path/to/file'.
+            If source files need to be required then they can be copied to the bin_dir with copy_to_bin.
     """
 
-    mappings = {}
+    mappings = {ctx.workspace_name: ["execroot", ctx.bin_dir.path]} if link_workspace_root else {}
     node_modules_root = ""
 
     # Look through data/deps attributes to find...

internal/linker/test/workspace_link/BUILD.bazel

@@ -0,0 +1,12 @@
+load("//packages/jasmine:index.bzl", "jasmine_node_test")
+
+jasmine_node_test(
+    name = "test",
+    srcs = ["test.js"],
+    link_workspace_root = True,
+    templated_args = ["--nobazel_patch_module_resolver"],
+    deps = [
+        "//internal/linker/test/workspace_link/bar",
+        "//internal/linker/test/workspace_link/foo",
+    ],
+)

internal/linker/test/workspace_link/bar/BUILD.bazel

@@ -0,0 +1,10 @@
+load("@build_bazel_rules_nodejs//:index.bzl", "copy_to_bin")
+
+copy_to_bin(
+    name = "bar",
+    srcs = [
+        "main.js",
+        "package.json",
+    ],
+    visibility = ["//internal/linker/test/workspace_link:__pkg__"],
+)

internal/linker/test/workspace_link/bar/main.js

@@ -0,0 +1,3 @@
+module.exports = {
+  bar: 'bar',
+}

internal/linker/test/workspace_link/bar/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "bar",
+  "main": "main.js",
+  "typings": "main.d.ts"
+}

internal/linker/test/workspace_link/foo/BUILD.bazel

@@ -0,0 +1,35 @@
+load("@build_bazel_rules_nodejs//:index.bzl", "copy_to_bin")
+load("@npm//typescript:index.bzl", "tsc")
+
+tsc(
+    name = "foo_lib",
+    outs = [
+        "main.d.ts",
+        "main.js",
+    ],
+    args = [
+        "-p",
+        "$(execpath tsconfig.json)",
+        "--outDir",
+        # $(RULEDIR) is a shorthand for the dist/bin directory where Bazel requires we write outputs
+        "$(RULEDIR)",
+    ],
+    data = [
+        "main.ts",
+        "tsconfig.json",
+    ],
+)
+
+copy_to_bin(
+    name = "foo_files",
+    srcs = ["package.json"],
+)
+
+filegroup(
+    name = "foo",
+    srcs = [
+        ":foo_files",
+        ":foo_lib",
+    ],
+    visibility = ["//internal/linker/test/workspace_link:__pkg__"],
+)

internal/linker/test/workspace_link/foo/main.ts

@@ -0,0 +1 @@
+export const foo: string = 'foo';

internal/linker/test/workspace_link/foo/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "foo",
+  "main": "main.js",
+  "typings": "main.d.ts"
+}

internal/linker/test/workspace_link/foo/tsconfig.json

@@ -0,0 +1,6 @@
+{
+  "compilerOptions": {
+    "declaration": true,
+    "types": []
+  }
+}

internal/linker/test/workspace_link/test.js

@@ -0,0 +1,8 @@
+describe('linker', () => {
+  it('should be able to require by absolute path when link_workspace_root is True', () => {
+    const foo = require('build_bazel_rules_nodejs/internal/linker/test/workspace_link/foo');
+    expect(foo.foo).toBe('foo');
+    const bar = require('build_bazel_rules_nodejs/internal/linker/test/workspace_link/bar');
+    expect(bar.bar).toBe('bar');
+  });
+});