Skip to content

Commit add1452

Browse files
authored
fix(jasmine): sharded test never fail when using Jasmine < 4 (#3360)
See: angular/dev-infra#463
1 parent 8606c50 commit add1452

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

e2e/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,9 @@ e2e_integration_test(
7070
# Old API
7171
"2.99.x",
7272
"3.9.x",
73+
"3.10.x",
7374
# New API
7475
"4.0.x",
75-
"3.10.x",
7676
]]
7777

7878
e2e_integration_test(

packages/jasmine/jasmine_runner.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,9 @@ async function main(args) {
146146

147147
// TODO(6.0): remove support for deprecated versions of Jasmine that use the old API &
148148
// remember to update the `peerDependencies` as well.
149-
// Jasmine versions prior to 3.10.0 should use the old API.
150-
if (/^3\.[1-9]\.|^2\./.test(jrunner.coreVersion())) {
151-
console.warn(`DEPRECATED: Support for Jasmine versions prior to '3.10.x' is deprecated in '@bazel/jasmine'.`);
149+
// Jasmine versions prior to 4.0.0 should use the old API.
150+
if (jrunner.coreVersion().charAt(0) !== '4') {
151+
console.warn(`DEPRECATED: Support for Jasmine versions prior to '4.0.x' is deprecated in '@bazel/jasmine'.`);
152152

153153
// Old Jasmine API.
154154
let noSpecsFound = true;

0 commit comments

Comments
 (0)