Skip to content

Commit d46502d

Browse files
authored
fix(typescript): remove protobufjs dependency (#3491)
protobufjs is not needed anymore by @bazel/typescript prototbufjs <6.11.3 is also vulnerable according to GHSA-g954-5hwp-pp24
1 parent c4a876c commit d46502d

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

packages/typescript/index.bzl

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -528,13 +528,6 @@ def ts_project(
528528
nodejs_binary(
529529
name = tsc_worker,
530530
data = [
531-
# BEGIN-INTERNAL
532-
# Users get this dependency transitively from @bazel/typescript
533-
# but that's our own code, so we don't.
534-
# TODO: remove protobuf dependency once rules_typescript also uses
535-
# worker package
536-
"@npm//protobufjs",
537-
# END-INTERNAL
538531
Label(typescript_package),
539532
Label("//packages/typescript/internal/worker:filegroup"),
540533
# BEGIN-INTERNAL

packages/typescript/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
"typescript": ">=3.0.0"
2424
},
2525
"dependencies": {
26-
"protobufjs": "6.8.8",
2726
"@bazel/worker": "0.0.0-PLACEHOLDER",
2827
"semver": "5.6.0",
2928
"source-map-support": "0.5.9",

0 commit comments

Comments
 (0)