Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle extras in entry_points.txt #1383

Closed
aignas opened this issue Aug 20, 2023 · 3 comments
Closed

Handle extras in entry_points.txt #1383

aignas opened this issue Aug 20, 2023 · 3 comments
Labels
Can Close? Will close in 30 days if there is no new activity P4

Comments

@aignas
Copy link
Collaborator

aignas commented Aug 20, 2023

This is split from #1363 as discussed in #1363 (comment)

See https://packaging.python.org/en/latest/specifications/entry-points/#data-model

aignas added a commit to aignas/rules_python that referenced this issue Aug 20, 2023
aignas added a commit to aignas/rules_python that referenced this issue Aug 22, 2023
aignas added a commit to aignas/rules_python that referenced this issue Aug 23, 2023
@aignas
Copy link
Collaborator Author

aignas commented Nov 20, 2023

I guess the relative priority of this feature is low given that the usage of extras for the entry_points is no longer recommended (see here):

Using extras for an entry point is no longer recommended. Consumers should support parsing them from existing distributions, but may then ignore them. New publishing tools need not support specifying extras. The functionality of handling extras was tied to setuptools’ model of managing ‘egg’ packages, but newer tools such as pip and virtualenv use a different model.

@aignas aignas added the P4 label Nov 20, 2023
Copy link

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

@github-actions github-actions bot added the Can Close? Will close in 30 days if there is no new activity label May 18, 2024
@aignas
Copy link
Collaborator Author

aignas commented May 19, 2024

Not sure if there is a need to do this. Users who need this can request a package with extras in the requirements file and then use the entry points rule to get the entrypoint.

@aignas aignas closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? Will close in 30 days if there is no new activity P4
Projects
None yet
Development

No branches or pull requests

1 participant