Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: support repo prefixes and config settings in alias rendering #1756

Merged
merged 10 commits into from
Feb 15, 2024
Merged

internal: support repo prefixes and config settings in alias rendering #1756

merged 10 commits into from
Feb 15, 2024

Commits on Feb 14, 2024

  1. internal: support repo prefixes and config settings in alias rendering 

    Summary:
- introduce a whl_alias struct to make code more object oriented.
- make the interface of the function as small as possible.
- unify the bzlmod and legacy code paths.
- allow to specify arbitrary repo prefixes and config settings
  when generating aliases (split out from bazelbuild#1744).
    @aignas
    aignas committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    3054c6f View commit details
    Browse the repository at this point in the history

  2. fixup! internal: support repo prefixes and config settings in alias r… 

    …endering
    @aignas
    aignas committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    cf84eb8 View commit details
    Browse the repository at this point in the history

  3. Support the same test code on 6.4

    @aignas
    aignas committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    1d8fb10 View commit details
    Browse the repository at this point in the history

  4. Ensure that tests work the same under bzlmod and non-bzlmod

    @aignas
    aignas committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    99b7907 View commit details
    Browse the repository at this point in the history

  5. Update .bazelversion

    @aignas
    aignas authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    7c8f47d View commit details
    Browse the repository at this point in the history

  6. further cleanup and use dict as the main interface

    @aignas
    aignas committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    ec848ec View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Update python/private/bzlmod/pip.bzl 

    Co-authored-by: Richard Levasseur <richardlev@gmail.com>
    @aignas @rickeylev
    aignas and rickeylev authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    4ce9f6b View commit details
    Browse the repository at this point in the history

  2. comment: explain the test expectation normalization function

    @aignas
    aignas committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    f0ecdf2 View commit details
    Browse the repository at this point in the history

  3. improve tests and better explain the test helper

    @aignas
    aignas committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    d625627 View commit details
    Browse the repository at this point in the history

  4. fixup! improve tests and better explain the test helper

    @aignas
    aignas committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    598e864 View commit details
    Browse the repository at this point in the history