Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolchains): Add riscv64 linux platform to available toolchain platforms #1907

Merged
merged 4 commits into from
May 19, 2024

Conversation

JeffreyALaw
Copy link
Contributor

@JeffreyALaw JeffreyALaw commented May 17, 2024

This change adds support for the riscv64 linux platform to rules_python. It is one of two changes necessary to allow riscv64 linux platforms to bootstrap modern versions of bazel.

Before this change an attempt to bootstrap bazel would fail with this error:

ERROR: An error occurred during the fetch of repository 'python':
   Traceback (most recent call last):
        File "/home/ubuntu/.cache/bazel/_bazel_ubuntu/c892bce6f2ccb80708b13f24cc8fb67e/external/rules_python/python/private/toolchains_repo.bzl", line 139, column 38, in _toolchain_aliases_impl
                host_platform = get_host_platform(os_name, arch)
        File "/home/ubuntu/.cache/bazel/_bazel_ubuntu/c892bce6f2ccb80708b13f24cc8fb67e/external/rules_python/python/private/toolchains_repo.bzl", line 298, column 13, in get_host_platform
                fail("No platform declared for host OS {} on arch {}".format(os_name, arch))
Error in fail: No platform declared for host OS linux on arch riscv64

This change fixes that error.

Copy link

google-cla bot commented May 17, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@aignas
Copy link
Collaborator

aignas commented May 17, 2024

In general looks good to me, but would love this to be mentioned in the CHANGELOG.md file. Could you please update the Added section in there?

@JeffreyALaw
Copy link
Contributor Author

In general looks good to me, but would love this to be mentioned in the CHANGELOG.md file. Could you please update the Added section in there?

Added. Didn't know if y'all prefer separate commits or a squashed commit, so I left them separate.

@aignas
Copy link
Collaborator

aignas commented May 18, 2024

The commits get squashed when merged and then the PR description becomes the commit message for the squashed commit.

@aignas aignas enabled auto-merge May 19, 2024 04:08
@aignas aignas added this pull request to the merge queue May 19, 2024
Merged via the queue into bazelbuild:main with commit daf4224 May 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants