feat(bzlmod): Add a gazelle example #969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the label strings that the users would get when loading the `all_requirements` and `all_whl_requirements` from the generated `requirements.bzl`. Previous labels were not really useable under bzlmod, because they would not be visible to the consumer. Work towards bazelbuild#965
Allow setting conventions for each part of the external repo labels. This is also useful when creating multi-platform alias targets when using an approach described in 2022 bazelcon [1]. [1]: https://www.youtube.com/watch?v=Bjaiu8tZZhs Work towards bazelbuild#965.
Work towards bazelbuild#965.
aignas
force-pushed
the
gazelle-bzlmod-example
branch
from
c8cc46a
to
89a8c6b
Compare
|
Now also depends on #970 |
|
@aignas I was talking with @alexeagle, and he mentioned that we should only support one example. In the README.md we make a reference to the commit that contains the pre bzmod example. Thoughts? |
|
No I think the rules repo needs examples for WORKSPACE and MODULE.bazel for a couple years while users are migrating. My comment was about only maintaining one tutorial. |
|
@alexeagle, thanks for the clarification! |
|
This is getting stale, so I'll close this in favour of something else in the somewhat near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is no example on the
gazellesetup withbzlmod.Issue Number: #965
What is the new behavior?
This is the example.
Does this PR introduce a breaking change?
Other information
Depends on #966, #967, #968.