Preserve directory structure of source files when some are generated #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameron-martin
force-pushed
the
fix-1510
branch
3 times, most recently
from
1ba6b17
to
0acbfe8
Compare
When some input files are generated, the source files get symlinked to `bazel-out` so the generated and source files are in the same directory. This was implemented in bazelbuild#1340. However, the directory structure would get flattened since only the basename was used for the symlink location. Now the package-relative path is used. Fixes bazelbuild#1510.
cameron-martin
force-pushed
the
fix-1510
branch
from
0acbfe8
to
3d44856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When some input files are generated, the source files get symlinked to
bazel-outso the generated and source files are in the same directory. This was implemented in #1340. However, the directory structure would get flattened since only the basename was used for the symlink location. Now the package-relative path is used.Fixes #1510.