-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cc config info to dummy wasm32 cc toolchain #1532
Conversation
fixes building with new cc toolchain resolution flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kcking! Can you provide an stacktrace or example of the error you get without this change?
Sure thing, here's a more minimal repro of the issue: https://github.com/kcking/bazel-repro-1532 The stack trace is
I noticed a related issue bazelbuild/bazel#15304 was closed, but independently rules_rust should be providing a well-formed cc toolchain config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
Fixes building with new cc toolchain resolution flag
--incompatible_enable_cc_toolchain_resolution=1
, which I am using in a project that involves a cross-compiled native rust web-server serving rust compiled to wasm.