Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip leading '@'s for labels in the splicing manifest #1547

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Conversation

Wyverald
Copy link
Member

@Wyverald Wyverald commented Sep 9, 2022

These labels are only used for error reporting, so it's not necessary for them to be unambiguous.

See #1544 for more background.

Needed to flip bazelbuild/bazel#16196.

These labels are only used for error reporting, so it's not necessary for them to be unambiguous.
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UebelAndre UebelAndre merged commit 6dacd98 into main Sep 9, 2022
@Wyverald Wyverald deleted the wyv-fix-uls branch September 9, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants