Avoid rendering a mock root package when possible #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
force-pushed
the
unnecessary
branch
2 times, most recently
from
ae58c60
to
495435a
Compare
UebelAndre
force-pushed
the
unnecessary
branch
from
495435a
to
ed33bd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
Cargo.lockis a relatively new feature (#1426) which did not fully account for cases wherecrates_repositorywould be consumingCargo.lockfiles produced by Cargo. This change avoids adding thedirect-cargo-bazel-depstarget to manifests in cases where users did not usecrates_repository.packages, thus allowing Cargo defined lockfiles to be usable by the repository rule.closes #1447