Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary binary file #1755

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Remove unnecessary binary file #1755

merged 2 commits into from
Jan 5, 2023

Conversation

scentini
Copy link
Collaborator

@scentini scentini commented Jan 5, 2023 •
edited by UebelAndre
Loading

This .so is not used anywhere, and is the cause of #1701. The .so files we use for the tests under //test/versioned_dylib are compiled from source via cc_binarys.

@scentini scentini linked an issue Jan 5, 2023 that may be closed by this pull request
Security Policy violation Binary Artifacts #1701
Closed
@scentini scentini marked this pull request as ready for review January 5, 2023 13:55
UebelAndre
UebelAndre approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@scentini scentini enabled auto-merge (squash) January 5, 2023 14:14
@scentini scentini merged commit 203fe4b into bazelbuild:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UebelAndre UebelAndre UebelAndre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security Policy violation Binary Artifacts
2 participants
@scentini @UebelAndre