Add support for all_crate_deps when using bzlmod
#2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Sorry for the buildifier failures, wasn't sure exactly what command the buildkite workflow was running. Appears to be passing now! For anyone stuck in the future, try |
|
@illicitonion Judging by similar pull requests this seems like it might be in your arena? Could you please take a look when you have time? Thanks! |
illicitonion
approved these changes
Feb 9, 2024
cameron-martin
added a commit
to cameron-martin/rules_rust
that referenced
this pull request
Feb 18, 2024
bazelbuild#2461 changed the rendering of the hub repo to use canonical repository names, but incorrectly. Doing so wasn't necessary - instead we just need to do the resolution of the non-canonical label from the perspective of the hub repo rather than the consumer. Fixes bazelbuild#2483
UebelAndre
pushed a commit
that referenced
this pull request
Feb 18, 2024
#2461 changed the rendering of the hub repo to use canonical repository names, but incorrectly. Doing so wasn't necessary - instead we just need to do the resolution of the non-canonical label from the perspective of the hub repo rather than the consumer by using the `Label` constructor. Fixes #2483
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
all_crate_depsfunctionality in repositories created via bzlmod. An earlier update that added support for 3rd party crates with bzlmod intentionally left this functionality out.Some key things that I think should be reviewed:
crate_label_templateinextensions.bzlthe best approach? It requires a lot of hard-coding, and it seems like it might be possible to simplify but I'm not familiar enough with the code base to know how.generate_config_filemethod fromcrates_vendor.bzlthe right method to use for generating the cargo-bazel config? It seems like there are two places with similar logic (here and incrates_repositories.bzl(see Addrender_configattribute tocrates_vendor. #1832)