Flip swift.coverage_prefix_map default #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this flag makes objects, archives, and binaries built with coverage data entirely hermetic. The only downside is that the coverage reports generated from these binaries cannot be viewed in Xcode since it doesn't support handling relative paths. If users want the previous behavior they can specify `--features=-swift.coverage_prefix_map`
keith
requested review from
BalestraPatrick,
brentleyjones,
segiddins and
thii
as code owners
|
seems like this is the right default, and what we just did for objc bazelbuild/apple_support#190 |
brentleyjones
approved these changes
Feb 15, 2023
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
Using this flag makes objects, archives, and binaries built with coverage data entirely hermetic. The only downside is that the coverage reports generated from these binaries cannot be viewed in Xcode since it doesn't support handling relative paths. If users want the previous behavior they can specify `--features=-swift.coverage_prefix_map`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this flag makes objects, archives, and binaries built with
coverage data entirely hermetic. The only downside is that the coverage
reports generated from these binaries cannot be viewed in Xcode since it
doesn't support handling relative paths. If users want the previous
behavior they can specify
--features=-swift.coverage_prefix_map