Flip swift.remap_xcode_path default #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
requested review from
BalestraPatrick,
brentleyjones,
segiddins,
thii and
mattrobmattrob
as code owners
mattrobmattrob
approved these changes
Feb 17, 2023
This ensures absolute paths to Xcode internals aren't embedded in binaries. Theoretically this could affect debugging but realistically it seems lldb is always smart enough to pickup the right values even if these paths are relative.
keith
force-pushed
the
ks/flip-swift.remap_xcode_path-default
branch
from
c06c83d
to
d19112c
Compare
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
This ensures absolute paths to Xcode internals aren't embedded in binaries. Theoretically this could affect debugging but realistically it seems lldb is always smart enough to pickup the right values even if these paths are relative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures absolute paths to Xcode internals aren't embedded in
binaries. Theoretically this could affect debugging but realistically it
seems lldb is always smart enough to pickup the right values even if
these paths are relative.