[bzlmod] Add dependency on platforms #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalestraPatrick
requested review from
brentleyjones,
keith,
segiddins and
thii
as code owners
brentleyjones
approved these changes
Dec 23, 2022
I agree. |
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
This was discovered while registering the latest rules_swift release into the BCR and running the validation pipelines there. It was tricky to debug, but it seems like either a recent change in rules_swift or bzlmod and Bazel caused this to be required. bazelbuild/bazel-central-registry#327 Now that bzlmod is more stable, we should likely look into adding a bzlmod verification pipeline directly in this repo so we can catch regressions earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discovered while registering the latest rules_swift release into the BCR and running the validation pipelines there. It was tricky to debug, but it seems like either a recent change in rules_swift or bzlmod and Bazel caused this to be required.
bazelbuild/bazel-central-registry#327
Now that bzlmod is more stable, we should likely look into adding a bzlmod verification pipeline directly in this repo so we can catch regressions earlier.