Avoid matching lowercase files when fname_case feature is missing #13
Conversation
Put the BUILD, *.BUILD, and BUILD.* patterns behind a has('fname_case')
check so that on case-insensitive systems it doesn't false positive on
lowercase names. "build" is kind of a generic pattern if it's not
case-sensitive. Other patterns in vim's runtime/filetype.vim perform
similar checks.
See https://groups.google.com/d/topic/vim_dev/m0_mv6E63mE/discussion for
context.
Users can configure an explicit autocmd in their vimrc if they want the
case-insensitive match regardless.
| autocmd BufRead,BufNewFile *.bzl,BUILD,*.BUILD,BUILD.*,WORKSPACE setfiletype bzl | ||
| autocmd BufRead,BufNewFile *.bzl,WORKSPACE setfiletype bzl | ||
| if has('fname_case') | ||
| autocmd BufRead,BufNewFile BUILD,*.BUILD,BUILD.* setfiletype bzl |
There was a problem hiding this comment.
Does this mean that this will no longer match BUILD files on OSX?
There was a problem hiding this comment.
Yes, and likewise not on Windows.
There was a problem hiding this comment.
OSX doesn't have fname_case? I didn't see it mentioned in vim's help: "for Amiga, MS-DOS, and Windows this is not present".
There was a problem hiding this comment.
The poster on the mailing list says they're using OS X.
Also Vim sets CASE_INSENSITIVE_FILENAME on OS X: https://github.com/vim/vim/blob/v8.0.0563/src/os_mac.h#L91
There was a problem hiding this comment.
LGTM.
Note that these have already been added as part of vim/vim@6856393.
|
I would really rather we don't do this. At least, leave BUILD. That's the standard file name for BAZEL, even if it conflicts. If you want to guard *.BUILD or BUILD.*, ok (but I think this significantly neuters the usefulness of these). Also, the problem here reported is that there is a shell script called build. Should this be caught by a hash-bang declaration? |
|
Note that since Open Source was changed (which again, I'm -1 on in its current form for the reasons above), it makes even more sense to leave this as is. If you include this plugin, you're intentionally including it, which means that you to have BUILD files detected correctly. |
|
I was thinking in terms of this being the upstream for Vim, but you make a good point about people including this plugin explicitly. |
|
I agree it'd be a shame and didn't realize it affected OSX, too. I'll wait and see what happens on vim/vim#1340. Re keeping the case-insensitive behavior in this plugin, in general I'd prefer to not have standing diffs here that aren't merged into vim. If there's no workable solution for the built-in version, I guess it'd have to do, though. |
Put the BUILD, .BUILD, and BUILD. patterns behind a has('fname_case')
check so that on case-insensitive systems it doesn't false positive on
lowercase names. "build" is kind of a generic pattern if it's not
case-sensitive. Other patterns in vim's runtime/filetype.vim perform
similar checks.
See https://groups.google.com/d/topic/vim_dev/m0_mv6E63mE/discussion for
context.
Users can configure an explicit autocmd in their vimrc if they want the
case-insensitive match regardless.