osfs example #124
Closed
osfs example #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Edge <peter.edge@gmail.com>
| } | ||
|
|
||
| func (d *dir) Mkdir(ctx context.Context, request *fuse.MkdirRequest) (_ fs.Node, retErr error) { | ||
| if err := os.Mkdir(request.Name, request.Mode); err != nil { |
There was a problem hiding this comment.
should be filepath.Join(path, request.Name)
|
I've copied this and did some improvements/bugfixes in #145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Edge peter.edge@gmail.com
This is the start of the reference example I talked about in #120. It needs work, and actually for the parts that are implemented, I'd love advice about the optimal way to do it. But that's sort of the point - new users of bazil.org/fuse could use such an example.
Also similar to #83