Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkuptime contains IP and DSL uptime #72

Closed
TwentyWasHere opened this issue Nov 9, 2022 · 5 comments
Closed

linkuptime contains IP and DSL uptime #72

TwentyWasHere opened this issue Nov 9, 2022 · 5 comments
Milestone

Comments

@TwentyWasHere
Copy link

TwentyWasHere commented Nov 9, 2022

With a FritzBox 7950 (OS 7.29) as a data source I noticed that the field "linkuptime" contains increasing values both for IP and DSL in my InfluxDB2

Screenshot from the raw table from Grafana: https://prnt.sc/_eXt_OWGu3xy

The large integers are the DSL uptime the smaller ones the Internet uptime since the last IP address change. They are not alternating, and sometimes there are multiple IP or DSL uptimes in the table before the other shows up again.

These two uptimes should be in two different fields and not randomly written to the same.

@TwentyWasHere
Copy link
Author

TwentyWasHere commented Nov 10, 2022

Looked at the code. Three times "linkuptime" in tr609.py.

One for WANIPConn, WANPPPConnection and WANIPConnection each. I played a bit with renaming them and they clearly show different values. Fixed it for my locally, might do a PR.

@bb-Ricardo
Copy link
Owner

Hi, thank you for this issue.

Indeed this is not correct. I will have a look how to fix properly.

@bb-Ricardo bb-Ricardo added this to the 1.1.1 milestone Nov 10, 2022
@TwentyWasHere
Copy link
Author

TwentyWasHere commented Nov 11, 2022

I made the following fix locally here: TwentyWasHere@20da539

@bb-Ricardo
Copy link
Owner

Thank you for the change

@bb-Ricardo bb-Ricardo modified the milestones: 1.1.1, 1.2.0 Dec 2, 2022
@bb-Ricardo
Copy link
Owner

in current next-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants